tests to demonstrate async-to-async unloadAll(<type>) issue (#9151) #9185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these tests demonstrate the unloadAll() edge case described in #9151
After debugging these tests, I've reached the conclusion this issue cannot be reasonably addressed without a major rewrite of our GC behavior. The unload APIs have always been a poor-man's escape hatch with tons of caveats, and I'm inclined to believe the lift needed to fix this issue is large enough that its not the right time to pursue it unless someone just happens to really want a fun graph traversal optimization problem to hack on.
At some point we're going to want to remove the unload APIs anyway, either as part of exploring #8162 or whenever we land support for store forking.