-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add svelte signal configuration package #10041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally this seems like the right approach. We'll still want to implement the Request component, though with svelte having unfortunately deprecated?(demoted?) its slots API it may be more ergonomic to just use a RequestSubscription directly in svelte.
I'll get this rebased and bring it up to speed with the isolated-declarations work over the coming week.
@runspired What blocks us from using |
I am out for a week, but when I get back I will add a few more tests some, helper components, and get this over the line. |
The trouble with snippets is just the verbosity and the inverted control flow. By the time someone wires them up they may as well have just written their own if/else using the reactive SubscriptionState class directly. Reminds me of all the worst parts of contextual components in ember. |
a6046d1
to
5ac5bdc
Compare
If this PR updates API docs, preview them by:
pnpm install
in the root (if needed)pnpm preview
in the root