Skip to content

Add svelte signal configuration package #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jacojoubert
Copy link

If this PR updates API docs, preview them by:

  • install bun (if needed)
  • install volta and configure it for pnpm (if needed)
  • run pnpm install in the root (if needed)
  • run pnpm preview in the root

  • Read the full contributing documentation
  • If you do not have permission to add labels or run the test-suite in CI, a team member will do this for you.

@github-project-automation github-project-automation bot moved this to needs triage in EmberData Jun 28, 2025
@jacojoubert jacojoubert marked this pull request as draft June 28, 2025 15:20
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally this seems like the right approach. We'll still want to implement the Request component, though with svelte having unfortunately deprecated?(demoted?) its slots API it may be more ergonomic to just use a RequestSubscription directly in svelte.

I'll get this rebased and bring it up to speed with the isolated-declarations work over the coming week.

@jacojoubert
Copy link
Author

jacojoubert commented Jul 4, 2025

@runspired What blocks us from using snippets? They dropped slots because they dropped web component support. As far as I know there isn't any downside to snippets? I can build out the request component.

@jacojoubert
Copy link
Author

I am out for a week, but when I get back I will add a few more tests some, helper components, and get this over the line.

@runspired
Copy link
Contributor

What blocks us from using snippets? They dropped slots because they dropped web component support. As far as I know there isn't any downside to snippets? I can build out the request component.

The trouble with snippets is just the verbosity and the inverted control flow. By the time someone wires them up they may as well have just written their own if/else using the reactive SubscriptionState class directly. Reminds me of all the worst parts of contextual components in ember.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Status: needs triage
Development

Successfully merging this pull request may close these issues.

3 participants