Some more fixes #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for cargo-lite.conf in a subpackage, the code failed to find it because it both `cd`d into the subpackage directory and then tried to look for `path.join(subpackage_dir, 'cargo-lite.conf')`. I.e. instead of looking for `src/gl/cargo-lite.conf` it looked for `src/gl/src/gl/cargo-lite.conf`.
Some projects don't have a master crate but provide subpackages instead. Let's not fail if the `[build]` section's missing but `[subpackages]` is present.
When running the custom build command fails, this prints out a correct error message, return code, stdout and stderr.
|
Hi Tomas! I'd had a bunch of fixes I forgot to push that I've pushed now. I think most of these had been fixed... Sorry for the inconvenience :( |
|
Closed by 83e19eb |
|
Ah, no worries! This is looking pretty useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a hello-world repo, put this in my
cargo-lite.conf:typed
cargo-lite.py install, saw a few failures and fixed them. Not sure whether my usage is correct or if the gl* repos have the right stuff in their cargo-lite.conf files.In case these are genuine bugs, feel free to merge them :-).