Update --print-pending logic to ignore existing pending modules that have no linting errors
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 4, 2019
bin/ember-template-lint.js
Outdated
| @@ -166,7 +166,13 @@ function run() { | |||
|
|
|||
| if (printPending) { | |||
| let failingRules = Array.from( | |||
| fileErrors.reduce((memo, error) => memo.add(error.rule), new Set()) | |||
| fileErrors.reduce((memo, error) => { | |||
| if (error.rule) { | |||
There was a problem hiding this comment.
Instead of making this kindof implicit, can we add a special .code / .rule value that we can check for?
I'm thinking we can tweak this:
ember-template-lint/lib/index.js
Lines 174 to 178 in 549775f
And add a rule: 'invalid-pending-module' or something.
What do you think?
There was a problem hiding this comment.
Great suggestion! Should be more clear now.
|
Friendly ping @gmurphey 😸 |
gmurphey
force-pushed
the
ignore-passing-pending
branch
from
288690e
to
77123ff
Compare
rwjblue
changed the title
--print-pending logic to ignore existing pending modules that have no linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was changing my rule configuration and running
ember-template-lint . --print-pendingto generate an updated pending list of files and noticed that there were some entries that looked like this:Debugging led me to realize these were being added to the output for
--print-pendingdue to an error being thrown during linting sayingPending module ('my/path/to/a/template') passes all rules. Please remove 'my/path/to/a/template' from pending list.This PR adds a check when building the output for
--print-pendingto make sure that the error thrown by the linter has a rule.Thanks for this great tool!