Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-curly-component-invocation to allow non-component yielded values to be used with mustaches #861

Conversation

patocallaghan
Copy link
Contributor

@patocallaghan patocallaghan commented Oct 16, 2019

Potential fix for #857

Opt out block param variables from curly invocation checks.

@rwjblue I noticed in that issue you mention

We could tweak things a bit so that the rule does not apply to block params when used without any arguments (e.g. {{foo}} vs either {{foo whatever}} or {{foo some=thing}}).

Is just checking if it's a block param enough or should we do additional checks?

@rwjblue rwjblue added the bug label Oct 17, 2019
@rwjblue rwjblue changed the title Don't throw lint errors on block params in curly invocation lint rule Update no-curly-component-invocation to allow non-component yielded values to be used with mustaches Oct 17, 2019
@rwjblue rwjblue merged commit 88598b9 into ember-template-lint:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants