Add blacklist support to simple-unless rule #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see how this is useful. Seems like a good feature to have. |
rwjblue
requested changes
May 29, 2019
lib/rules/lint-simple-unless.js
Outdated
| @@ -142,6 +147,14 @@ module.exports = class LintSimpleUnless extends Rule { | |||
| this._logMessage(message, loc.line, loc.column, actual); | |||
| } | |||
|
|
|||
| if (blacklist.length > 0 && blacklist.indexOf(param.path.original) > -1) { // blacklist.includes(param.path.original) | |||
There was a problem hiding this comment.
I think we can use .includes now (we dropped Node 4 support a little while back), mind swapping to that?
There was a problem hiding this comment.
Sounds good! Also updated a similar usage in the whitelist check above.
|
@mattbalmer - 👋 think you might have time to circle back to this one? Again, I'm sorry I let it linger so long after you initially submitted it... |
mattbalmer
force-pushed
the
feature/simple-unless-blacklist
branch
from
03f0644
to
7d66681
Compare
|
Hey, no worries and sorry for my own slow response! Your suggestion has been included, and the styles updated to match the new linter rules. Let me know if you spot any other changes you'd like! |
rwjblue
approved these changes
Jun 20, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A project I'm working on has need of a
blacklistfeature in conjunction with the 'simple-unless' rule. We would like to allow most cases for{{unless}}, but prevent certain helpers from being used with them.Code changes include adding that blacklist support, as well as modifying
maxHelpersto treat a value of-1as 'no limit'. This is useful because otherwise, to use theblacklist, one would need to specify an arbitrarily large number formaxHelpers(as it would raise errors on helpers not in theblacklistwhen the limit, defaulted to 0, was reached).