Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table groups ordering enforcement when whitespace is present in table-groups rule #1393

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Fix table groups ordering enforcement when whitespace is present in table-groups rule #1393

merged 2 commits into from
Jun 28, 2020

Conversation

mongoose700
Copy link
Contributor

Previously encountering whitespace would incorrectly reset the currentAllowedIndex back to -1.

@mongoose700 mongoose700 mentioned this pull request Jun 28, 2020
Merged
@bmish
Copy link
Member

bmish commented Jun 28, 2020

Can you update the rule doc too to mention the rule ordering enforcement?

@bmish bmish added the bug label Jun 28, 2020
@bmish bmish changed the title Correctly enforce table groups ordering when there is whitespace Fix table groups ordering enforcement when whitespace is present in table-groups rule Jun 28, 2020
@bmish bmish merged commit 44c6f2c into ember-template-lint:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mongoose700 @bmish