(fix): Adds Prettier based on RFC 0628 - #22
Conversation
|
@kennethlarsen Please have a look at this too, when you get time :). This PR adds Prettier Linter rules based on Robert's RFC 628. |
| 1.8, | ||
| 1.9, | ||
| 1.10, | ||
| 1.1, |
There was a problem hiding this comment.
I don't fully grok this change, we already have 1.1 listed just above. I think this should still be 1.10.
There was a problem hiding this comment.
That was a prettier's --fix change 😮 . My bad, didn't realise that we already had a 1.1 and trusted prettier to go ahead with this fix. I will have it corrected. Now I believe, these should be strings in that case. Thoughts?
There was a problem hiding this comment.
That brings up another bug in the implementation that - whichever option we choose between 1.1 or 1.10 (displayed as 1.1) from the version dropdown, there is only 1.1 displayed in the dropdown and the changes corresponding to "from" and "to" versions shows only 1.10's changes. Moving it to a string might solve this problem, although that looks like a fairly bigger change. How do we go about implementing this @rwjblue, could you please help?
There was a problem hiding this comment.
Now I believe, these should be strings in that case
Yeah, probably should be strings.
There was a problem hiding this comment.
Seems like that is a preexisting issue, can you make an issue to fix it?
There was a problem hiding this comment.
Yeah sure I’ll work on it and move them to strings. Thanks 👍🏻
Co-authored-by: Robert Jackson <me@rwjblue.com>
|
Thanks @abhilashlr and thanks @rwjblue for the review ✨ |
3 participants
Fixes #13
npm run lint(JS, and HBS)npm run test