Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 393 - TOC rearranging #459

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Issue 393 - TOC rearranging #459

merged 2 commits into from
Feb 18, 2019

Conversation

MelSumner
Copy link
Member

If merged into the octane branch, this PR resolves issue #393 by re-ordering the table of contents (as outlined in RFC 431).

If merged into the octane branch, this PR resolves issue #393 by re-ordering the table of contents (as outlined in RFC 431).
@jenweber
Copy link
Contributor

Should this PR review & merge wait until we have pages for some of those topics? Anatomy of an app doesn't exist, for example.

@MelSumner
Copy link
Member Author

MelSumner commented Feb 16, 2019

@jenweber we were thinking that we would add in the sections in the octane branch, even if the page has no content. We want to be able to see the content gaps easily.

It's inline with the plan (https://emberjs.com/blog/2019/02/14/octane-guides.html)

@jenweber
Copy link
Contributor

@MelSumner can I get your help with the merge conflicts?

I am not confident about removing tutorials, since it necessitates infra work that I don't think we have time for before the preview. The others make sense to me. Can you share more about why you think tutorials should be removed at this stage? Thanks!

@jenweber jenweber changed the title Issue 393 Issue 393 - TOC rearranging Feb 16, 2019
@jenweber
Copy link
Contributor

locks explained that tutorials infra is mostly done already. Merged! 🎉 Thanks for your help!

@jenweber jenweber merged commit 5ee2ec7 into octane Feb 18, 2019
@jenweber jenweber deleted the issue/393 branch March 18, 2019 00:57
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this pull request Jul 19, 2020
If merged into the octane branch, this PR resolves issue ember-learn#393 by re-ordering the table of contents (as outlined in RFC 431).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants