Skip to content

Remove use of @ember/string #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Remove use of @ember/string #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions guides/release/models/customizing-adapters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,10 @@ underscore_case instead of dash-case you could override the

```javascript {data-filename=app/adapters/application.js}
import JSONAPIAdapter from '@ember-data/adapter/json-api';
import { underscore } from '@ember/string';

export default class ApplicationAdapter extends JSONAPIAdapter {
pathForType(type) {
return underscore(type);
return type.replace(/-/g, '_'); // blog-post-comment becomes blog_post_comment
}
}
```
Expand Down
3 changes: 1 addition & 2 deletions guides/release/models/customizing-serializers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,11 @@ payload. For example, if your backend returned attributes that are
method like this.

```javascript {data-filename=app/serializers/application.js}
import { underscore } from '@ember/string';
import JSONAPISerializer from '@ember-data/serializer/json-api';

export default class ApplicationSerializer extends JSONAPISerializer {
keyForAttribute(attr) {
return underscore(attr);
return attr.replace(/_/g, '-'); // blog_post_comment becomes blog-post-comment
}
}
```
Expand Down