Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Quickstart JavaScript code blocks to use Class Syntax #541

Closed
4 tasks
jenweber opened this issue Mar 1, 2019 · 2 comments
Closed
4 tasks

Change Quickstart JavaScript code blocks to use Class Syntax #541

jenweber opened this issue Mar 1, 2019 · 2 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented Mar 1, 2019

We'd love to have a volunteer for this! Please see Octane MVP for instructions about where to make your PR. Please only volunteer for this issue if you can open a PR by the end of the next day. Thanks for your help!

To-do

For this issue, we should only make "class syntax" changes to the code blocks within guides/release/getting-started markdown files. Later PRs will fix up the written explanations to go with them. Here's an example of converting to Class syntax:

// Before
import Controller from '@ember/controller';

export default Controller.extend({
  title: 'hello-world.app',
});
// After
import Controller from '@ember/controller';

export default class ApplicationController extends Controller {
  title = 'hello-world.app';
}
  • branch from the octane branch of the guides
  • See this guide's Native Classes explanation to learn about the changes you will have to make
  • Make changes to the code blocks to use class syntax
  • PR to the octane branch
@jenweber jenweber changed the title Change JavaScript code blocks in the Quickstart to use Class Syntax Change Quickstart JavaScript code blocks to use Class Syntax Mar 1, 2019
rajasegar pushed a commit to rajasegar/guides-source that referenced this issue Mar 1, 2019
1. Change Route example to class syntax in core concepts
2. Change PeopleList component to use class syntax
3. didRender example to class syntax
@rajasegar
Copy link
Contributor

I am working on it , raised a PR for the same, please let me know for anything.

MelSumner added a commit that referenced this issue Mar 4, 2019
[OCTANE] [CHORE] Quickstart JS to use Class Syntax #541
@MelSumner
Copy link
Member

Thank you @rajasegar for your work! 👍

lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
1. Change Route example to class syntax in core concepts
2. Change PeopleList component to use class syntax
3. didRender example to class syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants