Skip to content

Bump some deps, fix some lint #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ module.exports = {
// TODO: fix these and enable octane
'no-action': false,
'no-curly-component-invocation': false,
'no-duplicate-id': false,
'no-extra-mut-helper-argument': false,
'no-implicit-this': false,
'no-inline-styles': false,
'no-invalid-interactive': false,
Expand Down
6 changes: 3 additions & 3 deletions addon/components/docs-header/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
link=(component "docs-header/link")
)}}

<DocsHeader::SearchBox @query={{this.query}} @on-input={{action (mut this.query)}} />
<DocsHeader::SearchBox @query={{this.query}} @on-input={{set this "query"}} />

<DocsHeader::Link @on-click={{action (toggle "isShowingVersionSelector" this)}}>
<DocsHeader::Link @on-click={{toggle "isShowingVersionSelector" this}}>
<span data-test-id="current-version" data-version-selector class="docs-flex docs-items-center">

{{#if (eq this.currentVersion.key this.latestVersionName)}}
Expand Down Expand Up @@ -59,5 +59,5 @@
{{/if}}

{{#if this.isShowingVersionSelector}}
<DocsHeader::VersionSelector @on-close={{action (mut this.isShowingVersionSelector false)}} />
<DocsHeader::VersionSelector @on-close={{set this "isShowingVersionSelector" false}} />
{{/if}}
2 changes: 1 addition & 1 deletion addon/components/docs-viewer/template.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="md:docs-flex docs-w-full">
{{yield (hash
nav=(component "docs-viewer/x-nav")
main=(component "docs-viewer/x-main" onReindex=(action (mut this.pageIndex)))
main=(component "docs-viewer/x-main" onReindex=(set this "pageIndex"))
)}}

<DocsViewer::XCurrentPageIndex @pageIndex={{this.pageIndex}} />
Expand Down
6 changes: 3 additions & 3 deletions addon/components/docs-viewer/x-nav/template.hbs
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{{#if @media.isMobile}}
<div class="docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
<button {{action (toggle "isShowingMenu" this)}}
<button {{on "click" (toggle "isShowingMenu" this)}}
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
☰ Menu
</button>
</div>
{{/if}}

<div class="AddonDocs-DocsViewer-Nav docs-bg-grey-lightest docs-border-r docs-flex-no-shrink">
<nav onclick={{action (mut this.isShowingMenu) false}}
<nav onclick={{set this "isShowingMenu" false}}
class="
docs-absolute docs-right-0 md:docs-relative docs-shadow-lg md:docs-shadow-none docs-mr-2 md:docs-mr-0 md:docs-pl-2
docs-max-w-xs docs-w-90% md:docs-w-72 docs-z-10 docs-transition md:docs-sticky md:docs-top-0
Expand All @@ -19,7 +19,7 @@
<div class="docs-pt-px docs-mb-8 docs-px-3 md:docs-px-4 md:docs-max-h-screen md:docs-overflow-y-scroll">
{{#if @media.isMobile}}
<div class="docs-text-right">
<button onclick={{action (mut thisisShowingMenu) false}}
<button onclick={{set this "isShowingMenu" false}}
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline">
&times;
</button>
Expand Down
13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"broccoli-caching-writer": "^3.0.3",
"broccoli-debug": "^0.6.5",
"broccoli-filter": "^1.3.0",
"broccoli-funnel": "^3.0.6",
"broccoli-funnel": "^3.0.8",
"broccoli-merge-trees": "^4.2.0",
"broccoli-persistent-filter": "^3.1.0",
"broccoli-plugin": "1.5.1 - 5",
Expand All @@ -53,7 +53,7 @@
"ember-cli-babel": "^7.26.3",
"ember-cli-clipboard": "^0.15.0",
"ember-cli-htmlbars": "^5.7.1",
"ember-cli-postcss": "^7.0.0",
"ember-cli-postcss": "^7.0.2",
"ember-cli-string-helpers": "^6.1.0",
"ember-cli-string-utils": "^1.1.0",
"ember-cli-version-checker": "^5.1.0",
Expand All @@ -70,6 +70,7 @@
"ember-responsive": "^4.0.0",
"ember-router-generator": "^2.0.0",
"ember-router-scroll": "^4.0.2",
"ember-set-helper": "^2.0.1",
"ember-svg-jar": "^2.2.3",
"ember-tether": "^2.0.0",
"ember-truth-helpers": "^3.0.0",
Expand All @@ -89,7 +90,7 @@
"marked": "^0.8.2",
"pad-start": "^1.0.2",
"parse-git-config": "^3.0.0",
"postcss": "^8.2.1",
"postcss": "^8.3.5",
"postcss-import": "^14.0.0",
"postcss-nested": "^5.0.3",
"postcss-scss": "^4.0.0",
Expand All @@ -103,7 +104,7 @@
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.2.5",
"@ember/test-helpers": "^2.2.8",
"@embroider/test-setup": "^0.42.0",
"@fullhuman/postcss-purgecss": "^3.0.0",
"@glimmer/component": "^1.0.4",
Expand Down Expand Up @@ -135,12 +136,12 @@
"ember-resolver": "^8.0.2",
"ember-source": "~3.27.5",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^3.2.0",
"ember-template-lint": "^3.5.0",
"ember-test-selectors": "^5.0.0",
"ember-try": "^1.4.0",
"eslint": "^7.23.0",
"eslint-config-prettier": "^8.1.0",
"eslint-plugin-ember": "^10.3.0",
"eslint-plugin-ember": "^10.5.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^3.3.1",
"loader.js": "^4.7.0",
Expand Down
1 change: 1 addition & 0 deletions test-apps/new-addon/tests/dummy/app/templates/snippets.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
{{/docs-snippet}}

<DocsSnippet @name="your-angle-bracket-snippet-name.hbs">
{{!-- template-lint-disable no-duplicate-id --}}
<div id="foo">
{{#my-awesome-thing
some=true
Expand Down
Loading