Skip to content

Fixed deprecations this.property-fallback, with, and positional linkt… #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2021
Merged

Fixed deprecations this.property-fallback, with, and positional linkt… #831

merged 3 commits into from
May 21, 2021

Conversation

bgantzler
Copy link
Contributor

…o parms

RobbieTheWagner
RobbieTheWagner requested changes May 21, 2021
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Was just about to address this myself.

@RobbieTheWagner RobbieTheWagner merged commit e231bf8 into ember-learn:master May 21, 2021
@cah-brian-gantzler
Copy link
Contributor

OMG, must have been doing too many things. Sorry for leaving the debugger and developing addon in. I know better :(

@RobbieTheWagner
Copy link
Member

No worries @cah-briangantzler! I really appreciate the help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgantzler @cah-brian-gantzler @RobbieTheWagner