Skip to content

Conversation

@ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Dec 9, 2019

This PR replace all single quotes to double quotes.

Why?

  • It wasn't consistent across this project
  • Ember app comes with double quotes by default
  • You can't copy paste examples without introducing linting errors in a new App

@RobbieTheWagner
Copy link
Member

@ctjhoa I think we need to also update some tests?

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Dec 9, 2019

@ctjhoa I think we need to also update some tests?

Yeah I saw this...

@RobbieTheWagner RobbieTheWagner merged commit eab7693 into ember-learn:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants