Skip to content

dependabot: Add a config #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2019
Merged

dependabot: Add a config #416

merged 2 commits into from
Oct 26, 2019

Conversation

dcyriller
Copy link
Contributor

Description

Would you accept a Dependabot config to automate dependencies upgrade?

Details

This config runs dependabot on a weekly basis (not to be too verbose). It can also be run on a montly basis if you prefer.

This config should also auto-merge in-range updates. To enable that feature, you'll have to visit https://app.dependabot.com/accounts/ember-cli-addon-docs/settings and tick the box Allow auto-merging to be enabled on projects.

To enable squash and merge for dependabot PRs, you'll have to untick the box Create a merge commit if a PR is merged by Dependabot.

With the version_requirement_updates: auto option, Dependabot should:

  • increase versions in the devDependencies
  • widen ranges in the dependencies

@RobbieTheWagner
Copy link
Member

This LGTM! @samselikoff any objections?

@samselikoff
Copy link
Contributor

samselikoff commented Oct 25, 2019

Looks good, I don't see any reason not to do daily. That's what we do on our projects.

Also it might be worth adding

    ignored_updates:
      - match:
          dependency_name: "ember-cli"

so we can do that ourselves, because I believe ember-cli updates typically are best done with ember-cli-update to bring along any changes to blueprint files with them.

Here's an example from one of our projects: https://github.com/embermap/ember-cli-fastboot-testing/blob/master/.dependabot/config.yml

@RobbieTheWagner
Copy link
Member

@samselikoff I think it might be good to ignore all deps that might be updated by ember-cli-update, and handle the ember updates separately. Would love to create a bot that runs ember-cli-update, but haven't had the time yet.

@samselikoff
Copy link
Contributor

samselikoff commented Oct 25, 2019 via email

@RobbieTheWagner
Copy link
Member

@samselikoff fair enough 👍 @dcyriller can you update per Sam's comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants