Adding tests for docs-page blueprint #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samselikoff @dfreeman @pzuraq My guilt for submitting code with no tests is no more! |
scalvert
commented
Apr 6, 2019
| @@ -98,7 +96,7 @@ function writeRoute(action, name, options) { | |||
|
|
|||
| function updateDocsTemplate(options) { | |||
| let routeName = options.entity.name; | |||
| let docsTemplatePath = options.pods | |||
| let docsTemplatePath = options.pod | |||
There was a problem hiding this comment.
Found this wee bug while I was writing tests. I guess I missed it with my manual testing (I'm old and senile...)
|
wow - useful examples to have for future reference as well! Nice work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, I've circled back and updated the node tests to include blueprint tests for
docs-pagenow that our node tests use mocha/chai.This PR:
ember-cli-blueprint-test-helperspackagedocs-pagefor both non-pods and pods