Skip to content

Fix usage of a test selector on a tagless component #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Mar 23, 2019

This is just an updated version of #271, because I'm currently blocked by this issue and would like it to land.

@czosel
Copy link
Contributor Author

czosel commented Mar 23, 2019

Looks like the CI issue magically resolved itself! 🎉

@czosel czosel force-pushed the fix-test-selectors branch from c2f6971 to 2ffa6f9 Compare March 23, 2019 16:29
@czosel czosel force-pushed the fix-test-selectors branch from 2ffa6f9 to 235e9ce Compare March 23, 2019 16:32
@dfreeman
Copy link
Contributor

dfreeman commented Apr 4, 2019

Thanks @czosel, and sorry this issue has lingered for so long!

@dfreeman dfreeman merged commit a5889c4 into ember-learn:master Apr 4, 2019
@czosel
Copy link
Contributor Author

czosel commented Apr 4, 2019

No worries, thanks for merging! 🙂

@czosel czosel deleted the fix-test-selectors branch April 4, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants