Use CSS Custom Property for brand color #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has some debt. We can decide if we want the feature now or want to figure out a cleaner solution now.
If we could just use CSS Custom Properties, this would be super clean as the Tailwind config var would just be
--brand-primary. However, there's not full browser support, so I wanted to provide a fallback. The fallback is to define a vanillacolor:(or background-color or border-color) property before the variable use.I used a Tailwind Component to insulate the rest of the codebase from this knowledge, that way we can continue to use
docs-color-brandand have it work everywhere.I had to use
!importantbecause components come before utilities, so adocs-text-grey-darkwas overriding the brand color. If/when we get the router service in to improve the docs links in the header/nav components, this can be dropped.