Skip to content

Fix deploy logic for custom domains #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

Fix deploy logic for custom domains #301

merged 1 commit into from
Jan 21, 2019

Conversation

@samselikoff
Copy link
Contributor

@samselikoff samselikoff commented Jan 20, 2019

No description provided.

@samselikoff samselikoff requested a review from dfreeman January 20, 2019 00:46
@samselikoff
Copy link
Contributor Author

samselikoff commented Jan 20, 2019

should probs add some tests but this got my deploys working for http://www.ember-cli-mirage.com/versions/master/

@dfreeman
Copy link
Contributor

dfreeman commented Jan 21, 2019

Looks like CI is failing because of #298. If we can land on a solution for that, though, I think this can supercede #266 and we can maybe cut a v0.6.2 release.

@samselikoff samselikoff force-pushed the fix-deploy-logic-for-custom-domains branch from ce40a07 to d94cc60 Compare January 21, 2019 21:01
@samselikoff samselikoff merged commit b92e267 into master Jan 21, 2019
@samselikoff samselikoff mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfreeman dfreeman dfreeman approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samselikoff @dfreeman