Skip to content

Conversation

@gossi
Copy link
Contributor

@gossi gossi commented Nov 20, 2018

With version 0.6.0 and using angle bracket syntax inside your markdown files will actually brake the build.

This is not working:

<DocsDemo @class="docs-demo" as |demo|>
  {{#demo.example name='demo.hbs'}}
    <FooBar @label="fubar"/>
  {{/demo.example}}

  {{demo.snippet 'demo.hbs'}}
</DocsDemo>

This patch fixes the parser to not only handle curlies but also angle brackets :)

@samselikoff samselikoff merged commit c375233 into ember-learn:master Jan 18, 2019
@samselikoff
Copy link
Contributor

Ty!

@miguelcobain
Copy link
Collaborator

I think this broke something.

When I write a paragraph like this in my template.md:

Up until now the guides assumed you passed in an array of data to the `@data` argument of `<YetiTable>`.

the result is

screen shot 2019-01-23 at 17 43 46

However, if I change <YetiTable> to YetiTable> it works fine:

screen shot 2019-01-23 at 17 45 31

So, the opening < is making things look unformatted. Basically everything gets stuck inside a single <p>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants