Skip to content

Ember data 2 or 3 #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Ember data 2 or 3 #243

merged 1 commit into from
Sep 13, 2018

Conversation

ryanto
Copy link
Contributor

@ryanto ryanto commented Sep 11, 2018

This is a PR for Issue #242

It allows addon docs to accept a wider range of Ember Data versions. This way it won't conflict with the host addon's data dependency.

@ryanto ryanto mentioned this pull request Sep 11, 2018
@samselikoff samselikoff merged commit 98c4e1e into ember-learn:master Sep 13, 2018
@samselikoff
Copy link
Contributor

Thank you my dude 👊

cyril-sf pushed a commit to Addepar/ember-table that referenced this pull request Mar 13, 2019
Master fails because `ember-cli-addon-docs` has a too strict dependency on `ember-data`
See ember-learn/ember-cli-addon-docs#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants