Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/docs-viewer/x-main/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default Component.extend({
}
} else {
let file = appFiles
.filter(file => file.match(/template.+(hbs|md)/))
.filter(file => file.match(/\.(hbs|md)$/))
.find(file => file.match(path));

return `${projectHref}/edit/${primaryBranch}/tests/dummy/app/${file}`;
Expand Down
2 changes: 1 addition & 1 deletion addon/components/docs-viewer/x-main/template.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="lg:docs-px-4" data-page-index-target>
{{yield}}

<div class="docs-mt-16 docs-mb-8">
<div class="docs-mt-16 docs-mb-8" data-test-edit-page-link>
<a href={{editCurrentPageUrl}}
class='docs-transition docs-text-grey-darkest docs-opacity-50 docs-text-sm
hover:docs-opacity-75 docs-no-underline docs-border-b docs-border-grey hover:docs-border-grey-darkest'>
Expand Down
8 changes: 8 additions & 0 deletions tests/acceptance/sandbox/api/components-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,12 @@ module('Acceptance | Sandbox | API | components', function(hooks) {
assert.equal(indexItems.length, 13, 'correct number of items rendered');
assert.ok(indexItems.includes('_privateField'), 'private field rendered');
});

test('welcome page \'Edit this page\' link is correct', async function(assert) {
await visit('/sandbox');

const editThisPageLinkHref = await modulePage.editLink.href;

assert.equal(editThisPageLinkHref, 'https://github.com/ember-learn/ember-cli-addon-docs/edit/master/tests/dummy/app/pods/sandbox/index/template.md');
});
});
8 changes: 7 additions & 1 deletion tests/pages/api/module.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import BaseAddonPage from '../base';
import { collection, text } from 'ember-classy-page-object';
import { attribute, collection, text } from 'ember-classy-page-object';

const ModulePage = BaseAddonPage.extend({
navItems: collection({ scope: '[data-test-id="nav-item"]' }),
Expand All @@ -26,6 +26,12 @@ const ModulePage = BaseAddonPage.extend({
})
}),

// eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
editLink: {
scope: '[data-test-edit-page-link]',
href: attribute('href', 'a'),
},

// eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
index: {
scope: '[data-test-page-index]',
Expand Down