Skip to content

State of Frontend writeup #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2022
Merged

State of Frontend writeup #1118

merged 2 commits into from
Mar 3, 2022

Conversation

@MinThaMie
Copy link
Contributor

@MinThaMie MinThaMie commented Mar 3, 2022 •
edited
Loading

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Related Issue(s)

Sources

@MinThaMie MinThaMie requested a review from a team as a code owner March 3, 2022 07:40
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 3, 2022
@MinThaMie MinThaMie self-assigned this Mar 3, 2022
jaredgalanis
jaredgalanis approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@jaredgalanis
Copy link
Member

jaredgalanis commented Mar 3, 2022

Thank you! ❤️

@MinThaMie, oops, approved too early. Looks like one lint issue. :)

@MinThaMie
Fix linting
ead6420 
as usual I forgot that one new line :)
@jaredgalanis jaredgalanis merged commit 8c1dac4 into blog/embertimes-197 Mar 3, 2022
@jaredgalanis jaredgalanis deleted the MinThaMie-patch-1 branch March 3, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees

@MinThaMie MinThaMie

Labels

embertimes PR for an Ember Times issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MinThaMie @jaredgalanis