Skip to content

blog(embertimes197): 1st class templates RFC FCP #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2022
Merged

blog(embertimes197): 1st class templates RFC FCP #1114

merged 3 commits into from
Mar 2, 2022

Conversation

@chrisrng
Copy link
Member

@chrisrng chrisrng commented Feb 26, 2022 •
edited
Loading

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Related Issue(s)

Sources

@chrisrng chrisrng requested a review from a team as a code owner February 26, 2022 13:51
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 26, 2022
jaredgalanis
jaredgalanis approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jaredgalanis jaredgalanis merged commit 8f6d00c into blog/embertimes-197 Mar 2, 2022
@jaredgalanis jaredgalanis deleted the chrisrng-patch-2 branch March 2, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees

No one assigned

Labels

embertimes PR for an Ember Times issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisrng @jaredgalanis