Skip to content

Update search input component to glimmer #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: search-input: use render helper
Ember's this.render method and @ember/test-helpers's render method are
equivalent, but using @ember/test-helpers' render method is the
recommended approach. As such, let's go ahead and switch this over.

While we're here, let's re-enable this eslint rule as we no longer have
any violations.
  • Loading branch information
Geodewd549 committed Jul 24, 2022
commit f9f1e37a8e1728cb87a62ce77d8eb6495845082f
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ module.exports = {
'ember/no-new-mixins': 'off',
'ember/no-mixins': 'off',
'ember/require-tagless-components': 'off',
'ember/no-test-this-render': 'off',
'ember/no-classic-classes': 'off',
'ember/no-get': 'off',
'ember/no-classic-components': 'off',
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/components/search-input-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { fillIn, waitFor } from '@ember/test-helpers';
import { fillIn, render, waitFor } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { set } from '@ember/object';

Expand Down Expand Up @@ -155,7 +155,7 @@ module('Integration | Component | search input', function (hooks) {
];
});

await this.render(hbs`{{search-input}}`);
await render(hbs`{{search-input}}`);

await fillIn('#search-input', 'model');

Expand All @@ -171,7 +171,7 @@ module('Integration | Component | search input', function (hooks) {
return [];
});

await this.render(hbs`{{search-input}}`);
await render(hbs`{{search-input}}`);

await fillIn('#search-input', 'model');

Expand Down