ember-data landing page: use ember-data-overview module main if present #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of pairing with @jenweber
This allows the ember-data team to maintain and update the overview for ember-data directly with each release, falling back to a built-in overview for versions for which the library did not yet provide one.
I've configured it to use the main from the module
ember-data-overview
as opposed toember-data
to ensure that any old releases that hadember-data
as a module (current releases do not) won't accidentally trip into this behavior.We should consider expanding this for the ember-cli and ember.js teams to utilize as well, it would be quite easy to do.
The
ember-data-overview
page is filtered from the modules that will appear in the sidebar to prevent confusion, since it is already the primary link for the project. This also allows us to re-useember-data
module main as an explainer for that particular package vs for the project as a whole.