Skip to content

Fix scrolling issue on highlightjs code #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Fix scrolling issue on highlightjs code #716

merged 1 commit into from
May 7, 2020

Conversation

abhilashlr
Copy link
Member

Fixes #590

@locks locks requested a review from a team May 7, 2020 10:33
RobbieTheWagner
RobbieTheWagner approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I'm not familiar with the issue this is fixing, but overflow: auto sounds correct for adding scrolling.

@abhilashlr
Copy link
Member Author

abhilashlr commented May 7, 2020 •
edited
Loading

Seems fine to me. I'm not familiar with the issue this is fixing, but overflow: auto sounds correct for adding scrolling.

Yes it adds the scrolling in the parent container. The table that renders the code from highlightjs is now scrolling inside it.

@Gaurav0
Copy link
Contributor

Gaurav0 commented May 7, 2020

@locks How can I create a deployment for this pr?

@Gaurav0 Gaurav0 merged commit 294b7d5 into ember-learn:master May 7, 2020
@Gaurav0 Gaurav0 mentioned this pull request May 7, 2020
Closed
@abhilashlr abhilashlr deleted the patch-1 branch May 8, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaurav0 Gaurav0 Gaurav0 approved these changes

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code example in docs is cut off
4 participants
@abhilashlr @Gaurav0 @RobbieTheWagner @locks