Fix legacy redirects #376
Merged
Fix legacy redirects #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to write tests and refactor, but also would like to get it out quickly... if we decide to merge this I'll create a followup issue. |
locks
approved these changes
Oct 18, 2017
4 tasks
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
Update service.md with line number fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #355
oddly enough, this doesn't look like it was broke by 2.16. At some point we changed to fetching project revisions to determine fingerprinted releases. these routes weren't updated for that new sequence, so all i'm doing here is adding the followup fetch of project-version rev file.
Currently hard coding to 2.15.3 until we can add mapping code.