Skip to content

Deprecation Guide for Globals Resolver#155

Merged
jenweber merged 4 commits intoember-learn:masterfrom
Gaurav0:deprecation_guide_globals_resolver
Sep 20, 2018
Merged

Deprecation Guide for Globals Resolver#155
jenweber merged 4 commits intoember-learn:masterfrom
Gaurav0:deprecation_guide_globals_resolver

Conversation

@Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jun 29, 2018

This is my first draft for #153

Rendered


If at all possible, it is highly recommended that you transition to using ember-cli to build your Ember applications. Most of the community already uses it and it provides many benefits including a rich addon ecosystem.

However, if you dp have a custom build system, or are using Ember App Kit,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dp -> do

@jenweber
Copy link
Contributor

Thanks for writing this up! 1 or 2 edits to make:

  • please replace Slack with a link to Discord, now that's all finalized
  • take a look at this screenshot below. I think the app's formatting is possibly not what you might have expected compared to normal markup. I have no idea why bold does nothing in this app. You might want to choose a different way to emphasize the text.

Uploading Screen Shot 2018-09-14 at 11.05.20 PM.png…

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Sep 18, 2018

@jenweber I cannot see the screenshot.

@Gaurav0 Gaurav0 force-pushed the deprecation_guide_globals_resolver branch from d67b581 to 51bcde7 Compare September 18, 2018 14:58
@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Sep 18, 2018

rebased

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Sep 18, 2018

This PR fixes the bolding issue: #186

@jenweber
Copy link
Contributor

Awesome! Thank you for also fixing the bolded styling issue.

@jenweber jenweber self-requested a review September 20, 2018 02:41
@jenweber jenweber merged commit 0b5cb0e into ember-learn:master Sep 20, 2018
@Gaurav0 Gaurav0 deleted the deprecation_guide_globals_resolver branch September 20, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants