Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tailwind appendix #256

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Update Tailwind appendix #256

merged 1 commit into from
Apr 28, 2022

Conversation

bertdeblock
Copy link
Collaborator

@bertdeblock bertdeblock commented Apr 28, 2022 •
edited
Loading

Addresses #245 (comment).

  • autoprefixer and postcss are only needed if you include tailwindcss as a PostCSS plugin
  • Added the --minify flag to the tailwind:build script, since this is used for creating a production build

@netlify
Copy link

netlify bot commented Apr 28, 2022 •
edited
Loading

✅ Deploy Preview for ember-cli-guides ready!

Name Link
🔨 Latest commit 5fd6c6b
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/626a3b8699bc1b0008b5d1b5
😎 Deploy Preview https://deploy-preview-256--ember-cli-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bertdeblock bertdeblock mentioned this pull request Apr 28, 2022
Merged
@NullVoxPopuli
Copy link
Contributor

If you use pnpm, are you error/warning free?

@bertdeblock
Copy link
Collaborator Author

When using pnpm, I don't have any errors or warnings saying that postcss and/or autoprefixer should be installed directly in my project.

@NullVoxPopuli
Copy link
Contributor

oh neat!

NullVoxPopuli
NullVoxPopuli approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for updating this, and updating my brain

@jenweber jenweber self-requested a review April 28, 2022 13:49
jenweber
jenweber approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y’all are the best! Thanks for your work on this and attention to detail with improvements.

@jenweber jenweber merged commit d5cc62d into ember-learn:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

@jenweber jenweber jenweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertdeblock @NullVoxPopuli @jenweber