Moved the script tag fastboot-body-start boundary in _finalizeHTML method #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratiahuja
reviewed
Sep 11, 2018
| this._head = head; | ||
| this._body = body; | ||
|
|
||
| // Adding script boundary around the body |
Contributor
There was a problem hiding this comment.
Can you add a test for when domContents is called these script boundaries are always present?
Author
There was a problem hiding this comment.
Thank you @kratiahuja, I added unit tests to verify domContents.body will always include boundary script tags.
* issue ember-fastboot#193 * Added unit tests to check domContents.body includes boundary script tag
dnalagatla
force-pushed
the
dnalagatla/update_body_in_domContents
branch
from
8f86795 to
3a5042d
Compare
Contributor
|
LGTM! Thanks @dnalagatla ! |
Contributor
|
released as v1.2.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #193