Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Comments being lost around modules #199

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix Comments being lost around modules #199

merged 2 commits into from
Sep 9, 2019

Conversation

NullVoxPopuli
Copy link
Contributor

Related: #198

@NullVoxPopuli NullVoxPopuli mentioned this pull request Sep 6, 2019
Closed
@NullVoxPopuli NullVoxPopuli changed the title Demonstrate comments are removed during transform Fix Comments being lost around modules Sep 9, 2019
rwjblue
rwjblue approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, definitely fixes the reported issue RE: module specific comments but I suspect we still have some issues here to iron out WRT to comments.

Happy to land this fix, and iterate as new scenarios crop up.

@rwjblue rwjblue merged commit 9aa00b5 into ember-codemods:master Sep 9, 2019
@rwjblue rwjblue added the bug label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @rwjblue