Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal clean up for contributing #48

Merged
merged 1 commit into from Dec 19, 2017
Merged

internal clean up for contributing #48

merged 1 commit into from Dec 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2017

Shamelessly copied config from ember core repos. This repo could probably use upgrading ember-cli, but that can be done separately.

  • use eslint instead of jshint
  • disable lockfile generation from npm

@ghost
Copy link
Author

ghost commented Dec 19, 2017

I'm running into ember-cli errors trying to test locally so I'm just going to update ember-cli to latest stable.

@rwjblue
Copy link
Member

rwjblue commented Dec 19, 2017

I'm running into ember-cli errors trying to test locally so I'm just going to update ember-cli to latest stable.

👍

@ghost
Copy link
Author

ghost commented Dec 19, 2017

I'll squash once everything passes.

* update ember-cli and relevant files
* use eslint instead of jshint
* disable lockfile generation from npm
@stefanpenner stefanpenner merged commit bff6ff6 into ember-cli:master Dec 19, 2017
@ghost ghost deleted the topic-contributer-cleanup branch December 19, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants