Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support ember-qunit@5 #652

Merged
merged 16 commits into from
Feb 17, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing ember try cases to remove qunit in mocha branch
  • Loading branch information
thoov committed Feb 16, 2021
commit de30bfbeced0e86c828867523d8828ea7b387d45
55 changes: 25 additions & 30 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@

const getChannelURL = require('ember-source-channel-url');
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
const mergeWith = require('lodash.mergewith');

function mochaScenario(scenario = {}) {
return mergeWith({}, scenario, {
devDependencies: {
'chai-dom': '*',
'ember-cli-chai': '*',
'ember-mocha': '*',
'ember-qunit': null
}
});
}

const command = [
'ember',
Expand Down Expand Up @@ -88,14 +100,9 @@ module.exports = async function() {
}
}
},
{
name: 'ember-default-with-mocha',
npm: {
devDependencies: {
'ember-mocha': '*'
}
}
},
mochaScenario({
name: 'ember-default-with-mocha'
}),
{
name: 'ember-classic',
env: {
Expand All @@ -112,29 +119,17 @@ module.exports = async function() {
}
},
embroiderSafe(),
embroiderSafe({
name: 'embroider-safe-with-mocha',
env: {
EMBROIDER_TEST_SETUP_OPTIONS: 'safe'
},
npm: {
devDependencies: {
'ember-mocha': '*',
},
},
}),
embroiderSafe(
mochaScenario({
name: 'embroider-safe-with-mocha'
})
),
embroiderOptimized(),
embroiderOptimized({
name: 'embroider-optimized-with-mocha',
env: {
EMBROIDER_TEST_SETUP_OPTIONS: 'optimized'
},
npm: {
devDependencies: {
'ember-mocha': '*',
},
}
}),
embroiderOptimized(
mochaScenario({
name: 'embroider-optimized-with-mocha'
})
)
]
};
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"fixturify": "^1.2.0",
"istanbul": "^0.4.3",
"loader.js": "^4.7.0",
"lodash.mergewith": "^4.6.2",
"mocha": "^8.1.0",
"mocha-eslint": "^6.0.0",
"npm-run-all": "^4.1.5",
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10540,6 +10540,11 @@ lodash.merge@^4.4.0, lodash.merge@^4.6.0, lodash.merge@^4.6.2:
resolved "https://registry.yarnpkg.com/lodash.merge/-/lodash.merge-4.6.2.tgz#558aa53b43b661e1925a0afdfa36a9a1085fe57a"
integrity sha512-0KpjqXRVvrYyCsX1swR/XTK0va6VQkQM6MNo7PqW77ByjAhoARA8EfrP1N4+KlKj8YS0ZUCtRT/YUuhyYDujIQ==

lodash.mergewith@^4.6.2:
version "4.6.2"
resolved "https://registry.yarnpkg.com/lodash.mergewith/-/lodash.mergewith-4.6.2.tgz#617121f89ac55f59047c7aec1ccd6654c6590f55"
integrity sha512-GK3g5RPZWTRSeLSpgP8Xhra+pnjBC56q9FZYe1d5RN3TJ35dbkGy3YqBSMbyCrlbi+CM9Z3Jk5yTL7RCsqboyQ==

lodash.omit@^4.1.0:
version "4.5.0"
resolved "https://registry.yarnpkg.com/lodash.omit/-/lodash.omit-4.5.0.tgz#6eb19ae5a1ee1dd9df0b969e66ce0b7fa30b5e60"
Expand Down