Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix projectName if there is no package.json name #1249

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Sep 28, 2023

Fixes #1248

Copy link

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mansona mansona merged commit 9285eb8 into master Sep 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-missing-name branch September 28, 2023 15:35
@mansona mansona added the bug label Sep 28, 2023
simonihmig added a commit to embroider-build/addon-blueprint that referenced this pull request Sep 29, 2023
Updates our blueprint for ember-cli/ember-cli-update#1249. Also adds additional test coverage for the generated config file.
simonihmig added a commit to embroider-build/addon-blueprint that referenced this pull request Sep 29, 2023
Updates our blueprint for ember-cli/ember-cli-update#1249. Also adds additional test coverage for the generated config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runs on v2 addon with wrong package name
2 participants