Why does this still use bower?

[BryanCrotaz]

ember-template-compiler is being requested from bower_components. Now that there's an npm package, should we not be using it?

I've upgraded my addon to ember 3.17 with ember upgrade, and I've run codemods. Now I'm getting a build error, Cannot find module ... bower_components/ember/ember-template-compiler.js

From reading the source code, it seems like ember-source is expected to be present. Should this be in the dependencies?

[BryanCrotaz]

ember install ember-cli-htmlbars neither installs ember-source, nor the required bower package.

[BryanCrotaz]

ember install ember-source is a working workaround, but the error message doesn't point the dev at this solution

[rwjblue]

I'm not sure I understand the question. We definitely do not use bower_components by default, though we do still have supporting code to discover the template compiler from there if we can't find it as a normal npm package.

[rwjblue]

Specifically, this code:

ember-cli-htmlbars/lib/ember-addon-main.js

Lines 194 to 199 in ff934eb

	let ember = this.project.findAddonByName('ember-source');
	if (ember) {
	return ember.absolutePaths.templateCompiler;
	} else if (!templateCompilerPath) {
	templateCompilerPath = this.project.bowerDirectory + '/ember/ember-template-compiler';
	}

It checks the project for ember-source, then falls back to the older bower_componetns/ember/ember-template-compiler.js location.

[rwjblue]

@BryanCrotaz - In your scenario, is the ember-source not found by this.project.findAddonByName('ember-source')?

[BryanCrotaz]

Yes, the above code is what led me to the solution, which narrows this down to being a misleading error message:

ember install ember-source is a working workaround, but the error message doesn't point the dev at this solution

[BryanCrotaz]

We shouldn't need to scour source code to find out how to fix an issue :)

[rwjblue]

1. I disagree that reading code is bad, it is quite wonderful and empowering 😄
2. I totally agree that we should fail loudly with a message about ember-source (not about bower_components) if we don't find the addon and bower_components/ember/ember-template-compiler.js is not present.

[BryanCrotaz]

It's wonderful and empowering, but it's not fast when you just want to get your upgrade done. It's fantastic when wanting to learn about Ember, but frameworks are valuable because you don't need to know everything about how they work. They just work.

[BryanCrotaz]

Also would be interesting to cross post this in ember-cli-update which should have installed ember-source during one of the updates?

[rwjblue]

Closed by #492