Skip to content

Add the gzipped file to the context's distFiles when keep is true #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ module.exports = {
return this._gzipFiles(distDir, distFiles, filePattern, keep)
.then(function(gzippedFiles) {
self.log('gzipped ' + gzippedFiles.length + ' files ok', { verbose: true });
if (keep) {
self.log('keep is enabled, added gzipped files to `context.distFiles`', { verbose: true });
return {
distFiles: gzippedFiles,
gzippedFiles: gzippedFiles
}
}
return { gzippedFiles: gzippedFiles };
})
.catch(this._errorMessage.bind(this));
Expand Down
33 changes: 24 additions & 9 deletions tests/unit/index-nodetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,30 @@ describe('gzip plugin', function() {
});
});

it('gzips the matching files with .gz suffix when keep is enabled', function(done) {
context.config.gzip.keep = true;
return assert.isFulfilled(plugin.willUpload(context))
.then(function(result) {
assert.deepEqual(result, { gzippedFiles: ['assets/foo.js.gz'] });
done();
}).catch(function(reason){
done(reason);
});
describe('when keep is enabled', function() {
beforeEach(function() {
context.config.gzip.keep = true;
});

it('gzips the matching files with .gz suffix', function(done) {
return assert.isFulfilled(plugin.willUpload(context))
.then(function(result) {
assert.deepEqual(result.gzippedFiles, ['assets/foo.js.gz']);
done();
}).catch(function(reason){
done(reason);
});
});

it('adds the gzipped files to the distFiles', function(done) {
return assert.isFulfilled(plugin.willUpload(context))
.then(function(result) {
assert.include(result.distFiles, 'assets/foo.js.gz');
done();
}).catch(function(reason){
done(reason);
});
});
});
});
});