Skip to content

Fix #14: only compress uncompressed files #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

buschtoens
Copy link

Fixes #14.

I also removed .swf from the list and added .json while I was at it.

References:

@buschtoens
Copy link
Author

Whoops, just discovered that this kind of reverts #7. Should I re-add .swf and squash?
@jasonkriss Were you able to measure any meaningful reduction in file size?

@jasonkriss
Copy link
Contributor

@buschtoens This definitely seems reasonable to me. #7 was kind of added just to mirror the ember-cli-deploy-manifest PR so I'm ok reverting it. Good work!

@buschtoens
Copy link
Author

👌

@ghedamat
Copy link
Contributor

LGTM @buschtoens !

lukemelia added a commit that referenced this pull request Dec 21, 2015
@lukemelia lukemelia merged commit 98367fc into ember-cli-deploy:master Dec 21, 2015
@lukemelia
Copy link
Collaborator

Danke!

@buschtoens
Copy link
Author

Gerne! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants