Fixing deprecation message. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ var Promise = require('ember-cli/lib/ext/promise'); | |||
|
|
|||
| module.exports = CoreObject.extend({ | |||
| init: function(plugin, revisions) { | |||
| this._super.init && this._super.init.apply(this, arguments); | |||
| this._super(); | |||
There was a problem hiding this comment.
Thanks for this @lcpriest . Should you be passing the args through to this._super?
There was a problem hiding this comment.
I was under the impression that was automatic - I'll update now.
There was a problem hiding this comment.
Oh, sorry mate. You might be right. I might be getting confused. I assume you've tested this to make sure it works then?
There was a problem hiding this comment.
To be honest, no. Should I just run the test suite? I wasn't using it directly in my code, it was a dependency of a package I was using.
|
sg @lcpriest thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
this._super is deprecated