Skip to content

Resolve core-object deprecation warnings. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jun 14, 2016

What Changed & Why

Explain what changed and why.

Related issues

Link to related issues in this or other repositories (if any)
Resolves #11.

PR Checklist

  • Add tests (n/a)? deprecation seems too high up the stack to catch?
  • Add documentation (n/a)? not needed
  • Prefix documentation-only commits with [DOC]

People

Mention people who would be interested in the changeset (if any)

@ghedamat ghedamat merged commit e50b721 into ember-cli-deploy:master Jun 15, 2016
@ghedamat
Copy link
Contributor

thanks @blimmer !

@blimmer
Copy link
Contributor Author

blimmer commented Jun 15, 2016

No problem @ghedamat - any chance to get a release for this? that yellow warning is coming up even when not deploying :-X

@blimmer blimmer deleted the resolve-core-object-deprecation branch June 15, 2016 15:32
@ghedamat
Copy link
Contributor

@blimmer done

can you test 0.2.2? thanks

@blimmer
Copy link
Contributor Author

blimmer commented Jun 16, 2016

thanks - confirmed fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPRECATION] overriding init without calling this._super
2 participants