Add request adapters#11
Merged
dokipen merged 5 commits intoembedly:masterfrom Jun 17, 2013
felipeelias:adapters
Merged
Conversation
Basically they're wrappers around the related library, and the idea is to make easy the switch and customization of new libraries
- tweaks in api, to make use of current requester class - adds related methods to configuration class, to make easy the switch between requesters - fix command line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new module called
Request. The idea is to remove duplication in theAPIclass by moving request related methods to their own class and allow the user to create its own requester class:This class is responsible to make the request. The user can register the new class in configuration and use it as follow:
After that, all api requests are made with the new request class. This allows users to user
faradaygem for example, without messing up with the api class.As an example, you can check that the
_do_typhoeus_callmethod was moved toEmbedly::Typhoeus::Request.