-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mieb] adding 10 tasks #1290
[mieb] adding 10 tasks #1290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Minor non-blocking suggestions.
date=("2024-01-01", "2023-07-01"), | ||
domains=["Academic"], | ||
task_subtypes=["Image Text Retrieval"], | ||
license="MIT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use lowercase for licenses.
eval_splits=["test"], | ||
eval_langs=["eng-Latn"], | ||
main_score="ndcg_at_5", | ||
date=("2024-01-01", "2023-07-01"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's flip this as date format is (from, to)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, fixed! Was a typo on my end (suppposed to be 2024-07-01).
Adding 10 tasks from vidore benchmark.
Checklist
make test
.make lint
.