Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mieb] adding 10 tasks #1290

Merged
merged 6 commits into from
Oct 15, 2024
Merged

[mieb] adding 10 tasks #1290

merged 6 commits into from
Oct 15, 2024

Conversation

gowitheflow-1998
Copy link
Contributor

Adding 10 tasks from vidore benchmark.

"VidoreArxivQARetrieval",
"VidoreDocVQARetrieval",
"VidoreInfoVQARetrieval",
"VidoreTabfquadRetrieval",
"VidoreTatdqaRetrieval",
"VidoreShiftProjectRetrieval",
"VidoreSyntheticDocQAAIRetrieval",
"VidoreSyntheticDocQAEnergyRetrieval",
"VidoreSyntheticDocQAGovernmentReportsRetrieval",
"VidoreSyntheticDocQAHealthcareIndustryRetrieval",

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor non-blocking suggestions.

date=("2024-01-01", "2023-07-01"),
domains=["Academic"],
task_subtypes=["Image Text Retrieval"],
license="MIT",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use lowercase for licenses.

eval_splits=["test"],
eval_langs=["eng-Latn"],
main_score="ndcg_at_5",
date=("2024-01-01", "2023-07-01"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's flip this as date format is (from, to).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, fixed! Was a typo on my end (suppposed to be 2024-07-01).

@gowitheflow-1998 gowitheflow-1998 merged commit 1b70f6d into mieb Oct 15, 2024
9 checks passed
@gowitheflow-1998 gowitheflow-1998 deleted the mieb-add-tasks branch October 15, 2024 14:03
@gowitheflow-1998 gowitheflow-1998 restored the mieb-add-tasks branch October 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants