Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: image, base64, sdl2 #55

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

sciguy16
Copy link
Contributor

Thank you for helping out with embedded-graphics-simulator development! Please:

  • Check that you've added passing tests and documentation
  • Add an example where applicable
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Hi, I noticed that the version of image this crate depends on in the published release is 0.23.4 (can be seen on the crates.io page rather than the 0.24.7 promised by the changelog. In the meantime, of course, there's been another version out so I've bumped the 3 now outdated dependencies to their latest versions.

I've also fixed some clippy warnings - let me know if you'd prefer that commit to be moved to a separate PR or if it's okay bundled in with this one.

@sciguy16
Copy link
Contributor Author

Ah, CI is failing because the bitstream-io transitive dependency of image has an MSRV of 1.79. Might have to back out the image update if we want it to build on 1.71

Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I don't know how the release version did get out of sync with the repo, but it seems that the release on crates.io is based on d11431f and not the latest commit at that time.

Ah, CI is failing because the bitstream-io transitive dependency of image has an MSRV of 1.79. Might have to back out the image update if we want it to build on 1.71

I wouldn't mind bumping the MSRV a bit, but I think we should at least support a couple of stable releases back if possible.

According to this issue the bump in the MSRV is caused by the ravif feature, which we don't use. By changing the image dependency we might be able to work around the issue:

image = { version = "0.25.1", default_features = false, features = ["png"] }

CHANGELOG.md Outdated Show resolved Hide resolved
@sciguy16
Copy link
Contributor Author

Good spot, I've turned off the default features on image and now the tests pass on 1.71

Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfuest rfuest merged commit 0c7e593 into embedded-graphics:master Jul 12, 2024
1 check passed
@sciguy16 sciguy16 deleted the dependencies branch July 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants