Add raw output to SimulatorDisplay #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method paniced if the display width or height was zero.
jamwaffles
approved these changes
Jun 1, 2021
If I remember correctly, the current version of the fonts in e-g was already generated with this patch applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
to_{be, le, ne}_bytesmethods toSimulatorDisplay. I'm using this feature in the new font conversion tool, which uses aSimulatorDisplayto draw the image of the glyphs. This image can then be exported to PNG and RAW files. IMO this feature could also be useful for other applications that need to generate data for use withRawImage.I've also changed the PNG compression to
Best. This can significantly reduce the size of the generated PNG files, which also reduces the size of the inlined images in the docs.