Fix shell formatting #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embed-me
reviewed
Jul 6, 2025
Owner
embed-me
left a comment
embed-me
left a comment
There was a problem hiding this comment.
Thank you for your Pull Request - just left one comment, rest looks good to me 👍
|
|
||
| (defun vunit--format-call-string (param) | ||
| "Format the VUnit call-string with `PARAM'." | ||
| (format "%s%s %s %s --output-path %s --no-color --num-threads %d %s" |
Owner
There was a problem hiding this comment.
Not every terminal worked well when color was enabled. Although it might not pretty it was a more robust solution to avoid formatting issues. What do you think about keeping it?
Contributor
Author
There was a problem hiding this comment.
Fine with me, let's keep the flag.
Later on, we can always make it a a defcustom, defaulting to no color.
Owner
There was a problem hiding this comment.
That is a good idea 👍
Would you be so kind to adapt your PR so that I can re-review and accept it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.