-
Notifications
You must be signed in to change notification settings - Fork 80
fix: notification issues #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lulf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I love the idea of introducing a GattConnection type for simplifying the API. I've left some comments inline on what changes I'd like to see.
I think in general that we should the existing GattData, GattEvent, but move the attribute server specific 'process()' into the GattConnection and/or GattConnectionEvent, to keep supporting the 'direct reply' use case without the attribute server.
|
Thanks for the feedback @lulf ! I think I've addressed everything. Two additional things have been tweaked:
|
lulf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good, thanks again @chrissuozzo!
|
/test |
Issue
Closes #308