Skip to content

Extend the task macro to allow cfging arguments away #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2023
Merged

Extend the task macro to allow cfging arguments away #2380

merged 2 commits into from
Dec 31, 2023

Conversation

MabezDev
Copy link
Contributor

Closes #2378

Dirbaio
Dirbaio reviewed Dec 31, 2023
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you add a test? You can use #[cfg(any())] to simulate a feature that's off and #[cfg(all())] to simulate one that's on.

Dirbaio
Dirbaio approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Dec 31, 2023
Merged via the queue into embassy-rs:main with commit 0be9b05 Dec 31, 2023
@MabezDev MabezDev deleted the cfg-task-args branch December 31, 2023 18:45
@MabezDev MabezDev mentioned this pull request Jan 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

embassy task: cannot cfg away task arguments

2 participants

@MabezDev @Dirbaio