Modernize 2-retrieval-qa-finish for LangChain v1 compatibility#8
Open
Flcookie wants to merge 1 commit into
Open
Modernize 2-retrieval-qa-finish for LangChain v1 compatibility#8Flcookie wants to merge 1 commit into
Flcookie wants to merge 1 commit into
Conversation
Author
|
Thanks for this amazing course and project! It really helped me understand RAG and LangChain in depth 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
2-retrieval-qa-finishbranch to be compatible with the latest LangChain v1 ecosystem.Changes
ingestion.py
langchain_text_splitters,langchain_openai, andlangchain_pinecone.backend/core.py
langchain_classicforcreate_retrieval_chainandcreate_stuff_documents_chain.Motivation
Keep the course code runnable under LangChain v1 while maintaining its original teaching structure and clarity.
Notes
If no local folder
langchain-docs/...exists,ingestion.pywill load 0 documents — this is expected.🙏 Acknowledgment
A huge thanks to the course author and contributors for creating such a clear and practical learning project.
It has been incredibly helpful for understanding how to build retrieval-augmented generation pipelines with LangChain.