Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a fluid AMP version of the template #283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JayOram
Copy link
Contributor

@JayOram JayOram commented Feb 14, 2022

Without changing the structure, only be editing the changes needed to make the original fluid template valid in AMP4Email.

Without changing the structure, only be editing the changes needed to make the original fluid template valid in AMP4Email
@TedGoas
Copy link
Collaborator

TedGoas commented Feb 14, 2022

I see you created a few file here, does that mean we'd need to go from three templates to six to support AMP? I'm wondering if it's worth it. There is some previous discussion about whether or not to support AMP. Would love to hear your take.

@JayOram
Copy link
Contributor Author

JayOram commented Feb 15, 2022

@TedGoas - as AMP supports classes and most HTML with less of the restrictions on HTML/CSS email templates, such as mso fixes/using th/hybrid/responsive/fluid etc. Just one version that I added would work for all of those modules in AMP.

@TedGoas
Copy link
Collaborator

TedGoas commented Feb 18, 2022

Just one version that I added would work for all of those modules in AMP.

What do you mean? Could we theoretically consolidate all three existing templates into a single AMP template since it's less code? Or would each template need it's own AMP version. Sorry for the dumb questions, I've not really worked with AMP emails before.

@JayOram
Copy link
Contributor Author

JayOram commented Feb 19, 2022

Apologies I didn't explain myself very well and you can ignore the original pull request.

I thought each version of the cerberus template was identical in modules. AMP only works in one way - the closest would be responsive.

  • No need for inline styles
  • All styles can go in the head and no need for important
  • As AMP is supported across clients, no need for mso specific fixes etc. the AMP code will work across all email clients that support AMP4Email

I will code all of the modules from all of the cerberus templates into 1x supported AMP4Email template. Then add a new pull request.

@TedGoas TedGoas added the question nothing reported, just asking a question label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question nothing reported, just asking a question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants