Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBSCRIBE and UNSUBSCRIBE #235

Merged
merged 3 commits into from
Apr 6, 2020
Merged

SUBSCRIBE and UNSUBSCRIBE #235

merged 3 commits into from
Apr 6, 2020

Conversation

ltgorm
Copy link
Contributor

@ltgorm ltgorm commented Mar 13, 2020

Adding support for imap commands SUBSCRIBE and UNSUBSCRIBE.
That way one can subcribe to, and unsubscribe from, specified mailboxes.

Copy link
Contributor

@nifgraup nifgraup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API change makes sense, best to receive list of mailboxes and operate on them without back and forth utf7 conversion.

@@ -348,16 +380,15 @@ export default class Client {
* http://tools.ietf.org/html/rfc3501#section-6.3.3
*
* @param {String} path
* The path of the mailbox you would like to create. This method will
* handle utf7 encoding for you.
* The path of the mailbox you would like to create.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme still talks about automatic utf7 handling.

@@ -373,14 +404,13 @@ export default class Client {
* https://tools.ietf.org/html/rfc3501#section-6.3.4
*
* @param {String} path
* The path of the mailbox you would like to delete. This method will
* handle utf7 encoding for you.
* The path of the mailbox you would like to delete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme still talks about automatic utf7 handling.

@nifgraup nifgraup merged commit 6d33f97 into emailjs:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants